Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAL-26 update password #47

Merged
merged 6 commits into from Oct 9, 2019

Conversation

@fetimo
Copy link
Contributor

commented Oct 9, 2019

No description provided.

@fetimo fetimo requested a review from SaloCreative Oct 9, 2019
@@ -165,11 +165,12 @@ const RenderFields = (props) => {
/>
);
}
case 'text':
case 'url':
case 'currentPassword':

This comment has been minimized.

Copy link
@fetimo

fetimo Oct 9, 2019

Author Contributor

This feels a bit messy but as we've used password as the other type I couldn't think of a better name/way.

const formShouldRender = !loading && !error && (showFormAfterSubmission || !submitted);
// check if form is stepped
const isStepper = renderSteps && !isEmpty(steps);
const Submit = CustomButton || Button;

This comment has been minimized.

Copy link
@fetimo

fetimo Oct 9, 2019

Author Contributor

Tidied up these definitions so they're all together.

@SaloCreative SaloCreative merged commit 806c42b into develop Oct 9, 2019
@SaloCreative SaloCreative deleted the feature/SAL-26-edit-password branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.