Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dynamic forms #5

Merged
merged 11 commits into from Sep 5, 2019

Conversation

@SaloCreative
Copy link
Collaborator

commented Sep 4, 2019

No description provided.

@SaloCreative SaloCreative requested a review from fetimo Sep 5, 2019

@SaloCreative SaloCreative changed the title WIP: Feature/dynamic forms Feature/dynamic forms Sep 5, 2019

@fetimo
fetimo approved these changes Sep 5, 2019
loading={ submit.isSubmitting }
type='submit'
>
{ get(textStrings, 'submit', 'Submit') }

This comment has been minimized.

Copy link
@fetimo

fetimo Sep 5, 2019

Contributor

I like, might be worth defining these in defaultProps so they'll all be in one place though

This comment has been minimized.

Copy link
@SaloCreative

SaloCreative Sep 5, 2019

Author Collaborator

I was originally going to merge the objects so everything had a fallback but doing it in the get() now. Couldn't think of a nice way to merge default and user defined props?

@fetimo fetimo merged commit c429f2b into develop Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.