Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sal 106 avatar class name #57

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@fetimo
Copy link
Contributor

fetimo commented Nov 1, 2019

Description

  • Passes className to Avatar
  • Linting applied to Avatar file
  • Updates node-sass so it works with Node 12

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My branch has no conflicts with the branch I want to merge into
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
@fetimo fetimo requested a review from SaloCreative Nov 1, 2019
@SaloCreative SaloCreative merged commit b2a8c6f into develop Nov 4, 2019
@SaloCreative SaloCreative deleted the feature/SAL-106-avatar-className branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.