Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to submit form data without nesting on a body key #72

Merged
merged 3 commits into from Jan 7, 2020

Conversation

@SaloCreative
Copy link
Collaborator

SaloCreative commented Jan 7, 2020

Description

Adding ability to submit form data without nesting on a body key

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the changelog
  • My branch has no conflicts with the branch I want to merge into
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
@SaloCreative SaloCreative requested a review from fetimo Jan 7, 2020
@fetimo
fetimo approved these changes Jan 7, 2020
@@ -250,6 +253,7 @@ Form.propTypes = {
mutationName: PropTypes.string, // Mandatory if passing mutation, mutation name to look up against
mutationVariables: PropTypes.object, // Any additional variables you need to pass when doing a custom mutation
name: PropTypes.string.isRequired,
nestedBody: PropTypes.bool, // Submit form feels nested in a body object

This comment has been minimized.

Copy link
@fetimo

fetimo Jan 7, 2020

Contributor

// Submit form feels … happy?

SaloCreative added 2 commits Jan 7, 2020
@fetimo
fetimo approved these changes Jan 7, 2020
@SaloCreative SaloCreative merged commit 8fea030 into master Jan 7, 2020
1 check passed
1 check passed
salo-core-ui/development Build passed
Details
@SaloCreative SaloCreative deleted the feature/update-useFormData-hook branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.