Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/form scroll #73

Merged
merged 5 commits into from Jan 7, 2020
Merged

Bugfix/form scroll #73

merged 5 commits into from Jan 7, 2020

Conversation

@SaloCreative
Copy link
Collaborator

SaloCreative commented Jan 7, 2020

Description

Fixing form scroll when changing page in stepped form

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the changelog
  • My branch has no conflicts with the branch I want to merge into
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
@SaloCreative SaloCreative requested a review from fetimo Jan 7, 2020
// Scroll form to top when page changes.
if (formRef) {
setTimeout(() => {
formRef.current.scrollIntoView();

This comment has been minimized.

Copy link
@fetimo

fetimo Jan 7, 2020

Contributor

I can't think what the exact case may be but I'm thinking something like if the component transitions/unmounts while submitting, it might be worth having an if statement or ?. before calling scrollIntoView.

@fetimo
fetimo approved these changes Jan 7, 2020
@SaloCreative SaloCreative merged commit f5aa04f into master Jan 7, 2020
1 check passed
1 check passed
salo-core-ui/development Build passed
Details
@SaloCreative SaloCreative deleted the bugfix/form-scroll branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.