Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor character count #83

Merged
merged 4 commits into from Feb 11, 2020
Merged

Added editor character count #83

merged 4 commits into from Feb 11, 2020

Conversation

@fetimo
Copy link
Contributor

fetimo commented Feb 10, 2020

Description

  • Added character count to Editor

Type of change

  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change)
@fetimo fetimo requested a review from SaloCreative Feb 10, 2020
@@ -230,14 +243,16 @@ WYSIWYG.defaultProps = {
className: '',
placeholder: '',
value: '',
onExport: null
onExport: null,
limit: 300

This comment has been minimized.

Copy link
@SaloCreative

SaloCreative Feb 11, 2020

Collaborator

Should probably default to null

@@ -230,14 +243,16 @@ WYSIWYG.defaultProps = {
className: '',
placeholder: '',
value: '',
onExport: null
onExport: null,
limit: 300

This comment has been minimized.

Copy link
@SaloCreative

SaloCreative Feb 11, 2020

Collaborator

Should probably default to null

@SaloCreative SaloCreative merged commit 5c41f1a into master Feb 11, 2020
1 check passed
1 check passed
salo-core-ui/development Build passed
Details
@SaloCreative SaloCreative deleted the feature/wysiwyg branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.