Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiselect #87

Merged
merged 7 commits into from Feb 13, 2020
Merged

Feature/multiselect #87

merged 7 commits into from Feb 13, 2020

Conversation

@SaloCreative
Copy link
Collaborator

SaloCreative commented Feb 13, 2020

No description provided.

@SaloCreative SaloCreative requested a review from fetimo Feb 13, 2020
@fetimo
fetimo approved these changes Feb 13, 2020
) }

{ !optionsLoading && optionsError && (
<MultiSelectErrorText>There was an error loading your data</MultiSelectErrorText>

This comment has been minimized.

Copy link
@fetimo

fetimo Feb 13, 2020

Contributor

In the future it might be nice to pass this message in

return <MultiSelectText className='salo-multi-select__values'>{ valueString }</MultiSelectText>;
};

const height = () => {

This comment has been minimized.

Copy link
@fetimo

fetimo Feb 13, 2020

Contributor

I know this is done elsewhere but it's probably worth passing this in as different projects are likely to have different requirements.

This comment has been minimized.

Copy link
@SaloCreative

SaloCreative Feb 13, 2020

Author Collaborator

Agreed....not sure why I even copied it haha

This comment has been minimized.

Copy link
@SaloCreative

SaloCreative Feb 13, 2020

Author Collaborator

I override it in FB anyway 🤦‍♂

@SaloCreative SaloCreative merged commit 0126bc1 into master Feb 13, 2020
1 check passed
1 check passed
salo-core-ui/development Build passed
Details
@SaloCreative SaloCreative deleted the feature/multiselect branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.