Merge pull request #363 from saloonphp/fix/allow-create-oauth-authent…

…icator-refresh-to-be-nullable Fix | Allow createOAuthAuthenticator method to have a nullable refresh token
saloonphp · Jan 18, 2024 · e956c73 · e956c73
2 parents 3222ff8 + dd2f671
commit e956c73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Traits/OAuth2/AuthorizationCodeGrant.php b/src/Traits/OAuth2/AuthorizationCodeGrant.php
@@ -161,7 +161,7 @@ protected function createOAuthAuthenticatorFromResponse(Response $response, stri
     /**
      * Create the authenticator.
      */
-    protected function createOAuthAuthenticator(string $accessToken, string $refreshToken, ?DateTimeImmutable $expiresAt = null): OAuthAuthenticator
+    protected function createOAuthAuthenticator(string $accessToken, ?string $refreshToken = null, ?DateTimeImmutable $expiresAt = null): OAuthAuthenticator
     {
         return new AccessTokenAuthenticator($accessToken, $refreshToken, $expiresAt);
     }

diff --git a/tests/Fixtures/Connectors/CustomResponseOAuth2Connector.php b/tests/Fixtures/Connectors/CustomResponseOAuth2Connector.php
@@ -15,7 +15,7 @@ class CustomResponseOAuth2Connector extends Connector
 {
     use AuthorizationCodeGrant;
 
-    
+
     public function __construct(protected string $greeting)
     {
         //
@@ -41,9 +41,9 @@ protected function defaultOauthConfig(): OAuthConfig
     }
 
     /**
-     * Define a custom OAuth2 authenticator.
+     * Create the OAuth authenticator
      */
-    protected function createOAuthAuthenticator(string $accessToken, string $refreshToken, DateTimeImmutable $expiresAt): OAuthAuthenticator
+    protected function createOAuthAuthenticator(string $accessToken, ?string $refreshToken = null, ?DateTimeImmutable $expiresAt = null): OAuthAuthenticator
     {
         return new CustomOAuthAuthenticator($accessToken, $this->greeting,  $refreshToken, $expiresAt);
     }