Tiny alteration of the fix in #202 #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of entirely re-binding the wrapped MiddlewarePipeline Closures, we can just use static Closures, which will prevent it from being bound to the specific instance.
We don't use the MiddlewarePipeline inside the wrapper Closures, and this feels less ugly and hacky than my previous fix (#202).
I also added more clarifying comments to the two wrapper-Closures.
I also noticed that the MiddlewarePipeline and the Pipelines are mutable, so we don't actually need to re-assign the properties.
I therefore removed that unnecessary re-assignment.
I hope that was ok.