Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed tests under ppc64, ppc64le #28

Closed
kubco2 opened this issue Oct 25, 2017 · 6 comments
Closed

Failed tests under ppc64, ppc64le #28

kubco2 opened this issue Oct 25, 2017 · 6 comments

Comments

@kubco2
Copy link

kubco2 commented Oct 25, 2017

Hello, I'm trying to package your library to Fedora but under ppc64, ppc64le tests failed. Do you support these architectures?

+ make test
"/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- LMDB_File.bs blib/arch/auto/LMDB_File/LMDB_File.bs 644
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-basic.t ........ ok
#   Failed test 'Default psize'
#   at t/01-environment.t line 58.
#          got: '32768'
#     expected: '4096'
# Looks like you failed 1 test of 175.
t/01-environment.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/175 subtests 
t/02-named.t ........ ok
MDB_MAP_FULL: Environment mapsize limit reached at /builddir/build/BUILD/LMDB_File-0.12/blib/lib/LMDB_File.pm line 370.
# Looks like your test exited with 255 just after 3.
t/03-fastmode.t ..... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 50/53 subtests 
t/04-bigone.t ....... ok
Test Summary Report
-------------------
t/01-environment.t (Wstat: 256 Tests: 175 Failed: 1)
  Failed test:  29
  Non-zero exit status: 1
t/03-fastmode.t   (Wstat: 65280 Tests: 3 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 53 tests but ran 3.
Files=5, Tests=245,  7 wallclock secs ( 0.05 usr  0.01 sys +  5.71 cusr  0.06 csys =  5.83 CPU)
Result: FAIL
Failed 2/5 test programs. 1/245 subtests failed.
make: *** [Makefile:963: test_dynamic] Error 255

You can look at https://koji.fedoraproject.org/koji/taskinfo?taskID=22677624 and https://koji.fedoraproject.org/koji/taskinfo?taskID=22677626

Thanks for reply.

@salortiz
Copy link
Owner

salortiz commented Oct 25, 2017 via email

@kubco2
Copy link
Author

kubco2 commented Oct 27, 2017

Unfortunately Im not perl developer nor user of LMDB. Can I help you somehow?
Is it possible to run tests with helpful messages? Some debug info which could help you? Then I can test your changes.

@kubco2
Copy link
Author

kubco2 commented Nov 6, 2017

ping

@kubco2
Copy link
Author

kubco2 commented Dec 12, 2017

I was playing a bit with this on ppc64 machine. And it looks like that only problem is that your tests are tied to unexpected default values.
e.g. default pagesize for Fedora 26 x86_64 = 4096

$ getconf PAGESIZE
4096

on Fedora 26 ppc64 = 65536

# getconf PAGESIZE
65536

If I change this line

StoreUV("psize", stat->ms_psize);

To 4096 and recompile on ppc64, then at least

#   Failed test 'Default psize'
#   at t/01-environment.t line 58.
#          got: '32768'
#     expected: '4096'
# Looks like you failed 1 test of 175.

This test success.

I think that it will be all about these errors in default sizes. Maybe you should recompute default expected values before tests start.

@salortiz
Copy link
Owner

salortiz commented Dec 12, 2017 via email

@kubco2
Copy link
Author

kubco2 commented Dec 13, 2017

Hello, I created pull request and fix things that block tests on ppc64. I left you some notes in pull request. I think I cant do more for you, Im not Perl nor C developer.

@kubco2 kubco2 closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants