Skip to content

Conversation

@oconnor663
Copy link
Contributor

As suggested by @Veykril: #1033 (comment)

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 0b06ea6
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6931b619b913020008d48a71

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #1034 will degrade performances by 7.82%

Comparing oconnor663:ordermap_optional (0b06ea6) with master (60d029a)

Summary

⚡ 1 improvement
❌ 1 regression
✅ 11 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
amortized[Input] 2.1 µs 2.2 µs -7.82%
amortized[InternedInput] 2.2 µs 2.1 µs +4.18%

@oconnor663
Copy link
Contributor Author

CodSpeed results look like they're within the error bars, and it's not really plausible that there would be an effect here :)

@MichaReiser MichaReiser added this pull request to the merge queue Dec 4, 2025
Merged via the queue into salsa-rs:master with commit 55e5e7d Dec 4, 2025
11 of 12 checks passed
@oconnor663 oconnor663 deleted the ordermap_optional branch December 4, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants