Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 support #16

Closed
wants to merge 5 commits into from
Closed

Python3 support #16

wants to merge 5 commits into from

Conversation

@cznewt
Copy link
Member

@cznewt cznewt commented Dec 27, 2017

No description provided.

@epcim
Copy link
Member

@epcim epcim commented Dec 28, 2017

Looks good, but we need PR against "develop" branch where the other features are already waiting...

@michaelkuty
Copy link
Member

@michaelkuty michaelkuty commented Dec 29, 2017

I think, that the develop branch should be rebased to this PR.

@epcim
Copy link
Member

@epcim epcim commented Dec 29, 2017

I know we did some commits directly to master, but for past months we agreed to stack-up other developers features on develop branch that we one day merge to master as the cleanest workflow. As of now develop count 180 commits above the master.

Note develop was already merged to master, but reverted shortly before xmass due issue 14.

@epcim epcim changed the base branch from master to develop Dec 29, 2017
@adrianchifor
Copy link

@adrianchifor adrianchifor commented Mar 19, 2018

Any update on this?

@epcim
Copy link
Member

@epcim epcim commented Mar 21, 2018

Any update on this?

must be rebased against develop (there are many commits with features that in days will land in "master")

@AndrewPickford
Copy link
Collaborator

@AndrewPickford AndrewPickford commented Mar 21, 2018

The changes should not penalise python2 users. For example the change of iteritems() to items() will be inefficient in python2. Better (at least according to http://python-future.org/compatible_idioms.html) to use the iteritems function:

from six import iteritems
for (key, value) in iteritems(dictionary):
epcim added a commit that referenced this pull request Mar 28, 2018
@adrianchifor
Copy link

@adrianchifor adrianchifor commented Apr 4, 2018

#23 to speed this up

epcim added 2 commits Apr 5, 2018
Rebase and other python3 compatibility changes/fixes.
One additional file (.DS_Store) will be fixed on python3 branch.
Similarly other possible issues, this is a valuable contribution.
@epcim epcim changed the base branch from develop to master Apr 5, 2018
@epcim epcim changed the base branch from master to develop Apr 5, 2018
@epcim
Copy link
Member

@epcim epcim commented Apr 5, 2018

GH has broken diff "again". Feel free to revert here. I would suggest moving focus to #25 and close this PR.

@epcim
Copy link
Member

@epcim epcim commented Apr 17, 2018

Closed in favor of #25

@epcim epcim closed this Apr 17, 2018
@epcim epcim deleted the python3 branch Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants