Python3 support #16
Python3 support #16
Conversation
|
Looks good, but we need PR against "develop" branch where the other features are already waiting... |
|
I think, that the develop branch should be rebased to this PR. |
|
I know we did some commits directly to master, but for past months we agreed to stack-up other developers features on develop branch that we one day merge to master as the cleanest workflow. As of now develop count 180 commits above the master. Note develop was already merged to master, but reverted shortly before xmass due issue 14. |
|
Any update on this? |
must be rebased against develop (there are many commits with features that in days will land in "master") |
|
The changes should not penalise python2 users. For example the change of iteritems() to items() will be inefficient in python2. Better (at least according to http://python-future.org/compatible_idioms.html) to use the iteritems function: from six import iteritems
for (key, value) in iteritems(dictionary): |
|
#23 to speed this up |
Rebase and other python3 compatibility changes/fixes. One additional file (.DS_Store) will be fixed on python3 branch. Similarly other possible issues, this is a valuable contribution.
|
GH has broken diff "again". Feel free to revert here. I would suggest moving focus to #25 and close this PR. |
|
Closed in favor of #25 |
No description provided.