Make formula relative to actual directory by using 'tpldir' #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvaSDK
approved these changes
May 9, 2018
Contributor
|
@noelmcloughlin can you test this and see if we can merge it? |
Contributor
|
Yes, no problem @aboe76 will test today. |
postgres/macos/postgresapp.sls
Outdated
| @@ -1,4 +1,4 @@ | |||
| {% from "postgres/map.jinja" import postgres as pg with context %} | |||
| {%- from salt.file.dirname(tpldir) ~ "/map.jinja" import postgres with context -%} | |||
Contributor
There was a problem hiding this comment.
Value needs to be 'pg'
Rendering SLS 'base:postgres.macos.postgresapp' failed: Jinja variable 'pg' is undefined
noelmcloughlin
suggested changes
May 11, 2018
Contributor
noelmcloughlin
left a comment
noelmcloughlin
left a comment
There was a problem hiding this comment.
LGTM on Salt 2018.03. One minor issue to fix.
mkotsbak
force-pushed
the
fix_relative_references
branch
from
d41f29c to
6903496
Compare
mkotsbak
force-pushed
the
fix_relative_references
branch
from
6903496 to
dd526f1
Compare
Contributor
Author
|
Ah, didn't notice that import line difference. Fixed, rebased and pushed PR branch again. |
Contributor
|
@mkotsbak and @noelmcloughlin thanks for your hard work |
Contributor
|
@EvaSDK thanks for the first review |
myii
added a commit
to myii/postgres-formula
that referenced
this pull request
Jan 24, 2019
aboe76
added a commit
that referenced
this pull request
Jan 24, 2019
Maintain consistent use of `tpldir` (continues from #211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the references are impossible to make realtive yes because of saltstack/salt#41195