Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes for nodegroups/log_granular_levels settings and small cleanups #77

merged 2 commits into from Dec 24, 2014


Copy link

rhertzog commented Dec 23, 2014

The first commit is a bugfix concerning the way we handle the nodegroups/log_granular_levels settings. The second commit is just a small cleanup for better Python 3 compatibility (and for consistency since both methods were already in use in this formula).

rhertzog added 2 commits Dec 23, 2014

Otherwise you get an “ValueError: too many values to unpack” exception
when you make use of those entries in your pillar data.
In Python 3, dict.items() is already an iterator while dict.iteritems() no
longer exits. In Python 2, dict.items() is not an iterator but it works
and the small performance hit doesn't really matter for the salt config
pillar data which is really small.
@rhertzog rhertzog changed the title Misc bugfixes FIxes for nodegroups/log_granular_levels settings and small cleanups Dec 23, 2014
babilen5 added a commit that referenced this pull request Dec 24, 2014
FIxes for nodegroups/log_granular_levels settings and small cleanups
@babilen5 babilen5 merged commit 98917ad into saltstack-formulas:master Dec 24, 2014

This comment has been minimized.

Copy link

babilen5 commented Dec 24, 2014


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.