Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent use of CryptError and ValueError #74

Closed
oconnor663 opened this issue Dec 31, 2015 · 1 comment
Closed

inconsistent use of CryptError and ValueError #74

oconnor663 opened this issue Dec 31, 2015 · 1 comment

Comments

@oconnor663
Copy link

crypto_box_open raises CryptError on failure, but crypto_box_open_afternm raises ValueError. Presumably they should raise the same thing?
@thatch45
Copy link
Contributor

thatch45 commented Mar 3, 2016

They should, good catch!

julianhille pushed a commit to julianhille/libnacl that referenced this issue May 10, 2017
Fix inconsistency in exceptions raised.
d1b25c0 
* crypto_box_open_afternm
* crypto_box_afternm

Fixes saltstack#74
@julianhille julianhille mentioned this issue May 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thatch45 @oconnor663