Fix inconsistency in exceptions raised. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* crypto_box_open_afternm * crypto_box_afternm Fixes saltstack#74
|
This should have been a major version increment as changing exceptions breaks API. Or, if you don't follow semantic versioning, please let me know. In this case, we'll need to do specific version pinning in our application. |
dbrgn
added a commit
to dbrgn/libnacl
that referenced
this pull request
Jul 25, 2017
The change in saltstack#91 is a breaking change for all applications that rely on catching encryption / decryption failures. Therefore it's important to mention it in the release notes.
|
My apologies @lgrahl , you are correct. I will be more careful in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74