Allow pinning minor 3xxx versions (3000.0, 3001.0, etc)#1491
Merged
Conversation
s0undt3ch
approved these changes
Aug 9, 2020
Contributor
|
Before merging we need to update the GH Actions to include minor pinning into the PR tests. The logic is in https://github.com/saltstack/salt-bootstrap/blob/develop/.github/workflows/templates/generate.py but the logic looks complex. I'll try to take a look on Monday. |
|
max-arnold/salt-bootstrap@pin-to-minor-post-neon...bryceml:test_0_version should add the tests if @s0undt3ch agrees with how that's done. |
Contributor
|
Yep, that's great Bryce! |
bryceml
approved these changes
Aug 18, 2020
s0undt3ch
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow pinning minor 3xxx versions. This is enabled by specifying a fake
.0version suffix:salt-bootstrap.sh -x python3 stable 3001.0What issues does this PR fix or reference?
#1436
Previously, it was impossible to have reproducible bootstrap process - a major 3xxx version install could mean 3xxx, 3xxx.1, 3xxx.2, etc. depending on the time of the install.
Also addressed the following comment: a321d51#r37765195
Note to reviewers: not sure if I added the test properly. Is
.kitchen.ymlthe right place?