Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pinning minor 3xxx versions (3000.0, 3001.0, etc) #1491

Merged
merged 5 commits into from Aug 18, 2020

Conversation

max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Aug 9, 2020

What does this PR do?

Allow pinning minor 3xxx versions. This is enabled by specifying a fake .0 version suffix:

salt-bootstrap.sh -x python3 stable 3001.0

What issues does this PR fix or reference?

#1436

Previously, it was impossible to have reproducible bootstrap process - a major 3xxx version install could mean 3xxx, 3xxx.1, 3xxx.2, etc. depending on the time of the install.

Also addressed the following comment: a321d51#r37765195

Note to reviewers: not sure if I added the test properly. Is .kitchen.yml the right place?

@s0undt3ch
Copy link
Member

Before merging we need to update the GH Actions to include minor pinning into the PR tests.

The logic is in https://github.com/saltstack/salt-bootstrap/blob/develop/.github/workflows/templates/generate.py but the logic looks complex. I'll try to take a look on Monday.

@bryceml
Copy link

bryceml commented Aug 18, 2020

max-arnold/salt-bootstrap@pin-to-minor-post-neon...bryceml:test_0_version should add the tests if @s0undt3ch agrees with how that's done.

@s0undt3ch
Copy link
Member

Yep, that's great Bryce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants