Missing summary for state commands in 2014.1.0 #10945

Closed
jaredlewis opened this Issue Mar 4, 2014 · 7 comments

Comments

Projects
None yet
3 participants

2014.1.0 release is missing the summary output when running a state command such as state.highstate or state.sls. I am running a local minion using the file_client: local config option. All other config options are default

Collaborator

basepi commented Mar 5, 2014

Hrm, I haven't noticed this missing, though I also don't use a masterless setup. We'll have to do some testing. Was the summary there previously (specifically in a masterless setup)?

@basepi basepi added Bug labels Mar 5, 2014

@basepi basepi added this to the Pending Discussion milestone Mar 5, 2014

@basepi yes previously it always showed the summary, i was upgrading from 0.17.5. Previously it would also output the names of the states being run. Now an example output looks something like this

pkg_|-python-pip_|-python-pip_|-installed:
                      ----------
                      __run_num__:
                          0
                      changes:
                          ----------
                      comment:
                          Package python-pip is already installed
                      name:
                          python-pip
                      result:
                          True

@basepi I believe I have figured it out. I just noticed this error

[DEBUG   ] Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/salt/output/__init__.py", line 35, in display_output
    display_data = get_printout(out, opts)(data).rstrip()
  File "/usr/lib/pymodules/python2.7/salt/output/highstate.py", line 44, in output
    return _format_host(host, hostdata)[0]
  File "/usr/lib/pymodules/python2.7/salt/output/highstate.py", line 130, in _format_host
    'comment': ret['comment'].strip().replace(
AttributeError: 'list' object has no attribute 'strip'

It looks like in previous versions of salt returning a list inside of a comment failed silently or was handled properly, but in the newest version it throws the previous error which causes the response to not be in the proper format and the summary to be missing.

Collaborator

basepi commented Mar 5, 2014

Ah, thanks for finding that! Should be straightforward to fix.

@basepi basepi modified the milestones: Outstanding Bugs, Pending Discussion Mar 5, 2014

cachedout added a commit to cachedout/salt that referenced this issue Mar 7, 2014

regilero added a commit to regilero/salt that referenced this issue Mar 7, 2014

Contributor

cachedout commented Mar 7, 2014

This should be fixed now. Thanks again for letting us know!

@cachedout cachedout closed this Mar 7, 2014

@cachedout thanks so much for fixing this!

Contributor

cachedout commented Mar 7, 2014

You're very welcome. Thanks for letting us know about this problem and
thanks so much for using Salt!

On Fri, Mar 7, 2014 at 10:12 AM, Ohhhh Yeahhhhhhhh <notifications@github.com

wrote:

@cachedout https://github.com/cachedout thanks so much for fixing this!

Reply to this email directly or view it on GitHubhttps://github.com/saltstack/salt/issues/10945#issuecomment-37045070
.

cachedout added a commit that referenced this issue Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment