New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh=True shouldn't run when package specifies version and it matches #13349

Closed
ryan-lane opened this Issue Jun 10, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@ryan-lane
Contributor

ryan-lane commented Jun 10, 2014

It's simply a time-sink to run apt-get update if a package is specifying a version and it's already at the correct version.

@basepi

This comment has been minimized.

Member

basepi commented Jun 10, 2014

True enough. Thanks for the report.

@basepi basepi added Bug labels Jun 10, 2014

@basepi basepi added this to the Approved milestone Jun 10, 2014

@ryan-lane

This comment has been minimized.

Contributor

ryan-lane commented Jun 10, 2014

Also, it shouldn't really run for pkg.installed either, if the package is already installed. The only really necessary case is when using pkg.latest, from what I can tell.

@garethgreenaway

This comment has been minimized.

Member

garethgreenaway commented Jul 3, 2014

I think I see a way to take care of the case where the desired package version is available and doesn't require an refresh. I wasn't seeing a refresh when the package was already installed though, even with refresh=True.

@UtahDave

This comment has been minimized.

Member

UtahDave commented Aug 4, 2014

@ryan-lane have you been able to verify that this fix works for you?

@basepi

This comment has been minimized.

Member

basepi commented Aug 5, 2014

I'm going to close this for now. If it isn't actually resolved, please comment!

@basepi basepi closed this Aug 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment