New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minion config options to be modified from salt-call #13515

Closed
ryan-lane opened this Issue Jun 17, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@ryan-lane
Contributor

ryan-lane commented Jun 17, 2014

There's a number of settings that would be ideal to be able to modify from salt-call, like root_dir, user, etc.. If we could modify arbitrary configuration from salt-call that would be nice.

@basepi

This comment has been minimized.

Member

basepi commented Jun 17, 2014

Do you mean a salt-call that actively modifies the configuration file, or just one-off configuration changes like --local or similar?

@basepi basepi added the Feature label Jun 17, 2014

@basepi basepi added this to the Approved milestone Jun 17, 2014

@ryan-lane

This comment has been minimized.

Contributor

ryan-lane commented Jun 17, 2014

A one-off. We use salt-call for orchestration (using states), so the different calls will never stumble over each other, but it's necessary to change their root dir so that cache and pidfiles and such don't conflict. This is just one example. I often find myself wanting to be able to modify the config options from the CLI.

@basepi

This comment has been minimized.

Member

basepi commented Jun 18, 2014

Hrm, I'm unsure of how we would do that. I suppose we could make a new flag that takes an argument, and have that argument be the configkey:value, maybe add some comma-separated.....something like

salt-call --config-mod=config1:value1,config2:value2 test.ping

Unless someone has a more elegant solution.

@AndreiPashkin

This comment has been minimized.

Contributor

AndreiPashkin commented Apr 14, 2016

state.highstate already provides localconfig option, which overrides config, but it accepts filepath. So it's possible to solve the problem by adding the same parameter which would accept JSON and YAML.

@stale

This comment has been minimized.

stale bot commented Apr 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Apr 23, 2018

@stale stale bot closed this Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment