Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failhard option to salt orchestration #22908

Closed
karanjad opened this issue Apr 21, 2015 · 3 comments · Fixed by #23389
Closed

Add failhard option to salt orchestration #22908

karanjad opened this issue Apr 21, 2015 · 3 comments · Fixed by #23389
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@karanjad
Copy link

Feature request;
Say in a long orchestration and one component failed and due to the requirements of the environment, it was necessary to stop the entire orchestration at the point of that failure.

@basepi
Copy link
Contributor

basepi commented Apr 24, 2015

I think orchestrate should already support failhard for specific pieces of the orchestrate run (much like state runs do, failhard is a global state argument). But we should definitely also have a global failhard option for orchestrate if it doesn't already exist.

@basepi basepi added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Core relates to code central or existential to Salt P3 Priority 3 labels Apr 24, 2015
@basepi basepi added this to the Approved milestone Apr 24, 2015
@karanjad
Copy link
Author

karanjad commented May 4, 2015

Lets say you have a scenario where you do not want to set a global failhard and the orchestration is taking place across different minions. In this situation, a failhard from one minion fails to stop the orchestration.

cachedout pushed a commit to cachedout/salt that referenced this issue May 5, 2015
@cachedout
Copy link
Contributor

This was actually already present but just needed a small fix to the state compiler to make it functional. I've made the necessary change in #23389. After that is merged, failhard will work in orchestrations.

@cachedout cachedout added the fixed-pls-verify fix is linked, bug author to confirm fix label May 5, 2015
rallytime pushed a commit to rallytime/salt that referenced this issue May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants