Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_hash from local file is not supported. #23764

Closed
es1o opened this issue May 15, 2015 · 3 comments
Closed

source_hash from local file is not supported. #23764

es1o opened this issue May 15, 2015 · 3 comments
Assignees
@jfindlay
Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Approved

Comments

@es1o
Copy link

es1o commented May 15, 2015

pyobjects salt code:

Archive.extracted('/dest',
    makedirs='True',
    archive_format='tar',
    user='user',
    group='user',
    mode='0755',
    source='file:///tmp/file.tar.gz',
    source_hash='file:///tmp/file.md5')

salt-call error:

Comment: Source hash file file:///tmp/file.md5 contains an invalid hash format, it must be in the format <hash type>=<hash>

Problem is in salt/modules/file.py in line:

protos = ['salt', 'http', 'https', 'ftp', 'swift', 's3']

should be:

protos = ['salt', 'http', 'https', 'ftp', 'swift', 's3', 'file']
@jfindlay jfindlay added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels May 18, 2015
@jfindlay jfindlay added this to the Approved milestone May 18, 2015
@jfindlay
Copy link
Contributor

@es1o, thanks for the report. Have you tested that change locally? You are welcome to submit a pull request for this. Be sure to reference this issue and submit the fix to the 2015.5 branch.

@es1o
Copy link
Author

es1o commented May 18, 2015

Yes, I tested this change locally and it works but I can't create pull request for this change.

@jfindlay
Copy link
Contributor

@es1o, nice, thanks. If you don't get around to submitting a pull request in the next several days, then don't worry, I'll take care of it.

@jfindlay jfindlay self-assigned this May 19, 2015
@notpeter notpeter mentioned this issue Jun 26, 2015
Merged
This was referenced Jul 24, 2015
Closed
Closed
Merged
alekti pushed a commit to alekti/salt that referenced this issue Aug 5, 2015
@alekti
Add file as supported protocol for file source_hash. Fixes saltstack#…
4b9d742 
…23764.

Conflicts:
	salt/modules/file.py
alekti added a commit to alekti/salt that referenced this issue Aug 5, 2015
@alekti
Revert "Add file as supported protocol for file source_hash. Fixes sa…
5a7cab4 
…ltstack#23764."

This reverts commit 4b9d742.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfindlay jfindlay

Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@es1o @jfindlay