Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterless Broken in 0.10.5 #2731

Closed
cwood opened this issue Nov 28, 2012 · 16 comments · Fixed by #2768

Comments

@cwood
Copy link

commented Nov 28, 2012

Posted this on IRC talking with pentabular

But it looks like 0.10.5 masterless is broken.

When I run

$ [vagrant@vagrant-centos-63 salt]$ sudo salt-call --local state.highstate
No handlers could be found for logger "salt.config"
Master hostname: salt not found. Retrying in 30 seconds

This is my config

file_client: local

file_roots:
  base:
    - /srv/salt

state_file: top.sls

Verison

[vagrant@vagrant-centos-63 salt]$ salt-call --version
salt-call 0.10.5
@ghost

This comment has been minimized.

Copy link

commented Nov 28, 2012

@s0undt3ch @benhosmer with the daily build --local makes it work, but without that I get the error: "WARNING: Master hostname: salt not found. Retrying in 30 seconds".

@benhosmer

This comment has been minimized.

Copy link
Member

commented Nov 28, 2012

@cwood and @s0undt3ch thanks for the issue. I was going to wait and see what the list said, but I'm glad it isn't something I'm doing wrong.

@cwood

This comment has been minimized.

Copy link
Author

commented Nov 28, 2012

Just to note this is coming from the rpms for centos 6.3 if I pull down from git the --local flag works. But still fails when running salt-call

@thatch45

This comment has been minimized.

Copy link
Member

commented Nov 28, 2012

Thanks for the heads up, I slated this for the next release so we don't miss it

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Nov 29, 2012

What's still failing here? If --local is not used, a configured master is required, right? Since it's not, it fails, or what have I missed?

@ghost

This comment has been minimized.

Copy link

commented Nov 29, 2012

it should not require --local if the minion is configured standalone according to https://salt.readthedocs.org/en/latest/topics/tutorials/standalone_minion.html

Is --local now required for standalone?

@thatch45

This comment has been minimized.

Copy link
Member

commented Nov 29, 2012

it should not be required, the config file should trump. @s0undt3ch, is this a problem with how the config values are loaded?

@benhosmer

This comment has been minimized.

Copy link
Member

commented Nov 29, 2012

@s0undt3ch Here is with the latest vagrant-salt gem that I just updated on my machine:

vagrant@precise64:~$ sudo salt-call state.highstate
No handlers could be found for logger "salt.config"
Master hostname: salt not found. Retrying in 30 seconds
^C
Exiting gracefully on Ctrl-c
vagrant@precise64:~$ sudo salt-call state.highstate --local
No handlers could be found for logger "salt.config"
Master hostname: salt not found. Retrying in 30 seconds
^C
Exiting gracefully on Ctrl-c
vagrant@precise64:~$ cat /etc/salt/minion
file_client: localvagrant@precise64:~$ 

Also, the new vagrant-salt gem doesn't seem to install latest from git, even if I set the config file to do so. I am going to post this issue in the vagrant-salt que.

@benhosmer

This comment has been minimized.

Copy link
Member

commented Nov 29, 2012

I was mistaken previously and didn't configure the new vagrant-gem. If use 0.10.4 everything works fine.

@akoumjian

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

bug is confirmed. Breaking everyone's salty-vagrant installs...

@thatch45

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

well this is a fine kettle of fish...

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

Arrggg...

Sometimes I love github's notifications, this time I'm hating it. I missed this last part of the conversation.

I'll investigate was missed here...

Sorry for the late reply.

Pedro Algarvio

----- Reply message -----
De: "Thomas S Hatch" notifications@github.com
Para: "saltstack/salt" salt@noreply.github.com
Cc: "Pedro Algarvio" pedro@algarvio.me
Assunto: [salt] Masterless Broken in 0.10.5 (#2731)
Data: sáb, Dez 1, 2012 02:42
well this is a fine kettle of fish...

Reply to this email directly or view it on GitHub.

@thatch45

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

Sorry, I have not looked at this one yet, but my guess is that the cli parser default over rides the config file, thanks @s0undt3ch !

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

Well, I have a fix, and it has nothing to do with parser defaults, please check this commit, still need to add a testcase for this. So, what parser defaults were you thinking of? I might have missed something.

@thatch45

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

should the default be "remote"?

@s0undt3ch

This comment has been minimized.

Copy link
Member

commented Dec 1, 2012

Well, it seems like it is.

s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Dec 1, 2012
@s0undt3ch s0undt3ch closed this in 16f8d4c Dec 2, 2012
thatch45 added a commit that referenced this issue Dec 2, 2012
Fix #2731 + Testcase + Some other fixes.
waynew added a commit to waynew/salt that referenced this issue Jul 26, 2019
From what I can tell, this test is no longer relevant. It was put in to
solve issue saltstack#2731, where Salt minions were checking DNS even when
`--local` was passed. Now the code to check the DNS for the master has
grown quite a bit more complex. In [salt/minion.py][1] if you simply
force `check_dns = True` (i.e. remove the `local` check), this test
will still pass running locally. If this test were effective at testing
whether or not the CLI was going to timeout, it should fail - but it
doesn't.

From what I can gather, there's no longer a good reason to run this
particular test.

[1]: https://github.com/saltstack/salt/blob/ffa70adec3ed5a1823976c7f32e37f165a9adb37/salt/minion.py#L138
waynew added a commit to waynew/salt that referenced this issue Jul 29, 2019
From what I can tell, this test is no longer relevant. It was put in to
solve issue saltstack#2731, where Salt minions were checking DNS even when
`--local` was passed. Now the code to check the DNS for the master has
grown quite a bit more complex. In [salt/minion.py][1] if you simply
force `check_dns = True` (i.e. remove the `local` check), this test
will still pass running locally. If this test were effective at testing
whether or not the CLI was going to timeout, it should fail - but it
doesn't.

From what I can gather, there's no longer a good reason to run this
particular test.

[1]: https://github.com/saltstack/salt/blob/ffa70adec3ed5a1823976c7f32e37f165a9adb37/salt/minion.py#L138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.