New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2016.3.0 FreeBSD Failed to load grains defined in grain file disks.disks in function <function disks at 0x80cff9320>, error: #33578
Comments
@ohauer I am not seeing these errors in these logs. Did you upgrade from a previous version? How did you install salt? Any other information that might help to replicate? |
I am also seeing this issue. I did upgrade salt from 2015.8.8_1 -> 2016.3.0. Salt was installed via the sysutils/py-salt port. My minion logs also display this when running I'm not sure if it's helpful, but when running |
Can you paste the output of 'geom disk list'? |
Sure, that's from one of my masters/syndic systems geom disk listGeom name: cd0
Geom name: da0
geom disk list (on a bare metal master in a remote office)Geom name: cd0
Geom name: ada0
Geom name: ada1
Geom name: ada2
|
If uploaded an archive with the output of grains.items from the same system Archive contains output on FreeBSD 10.x with salt 2015.5.8, 2015.8.10 and 2016.3.0 |
I'm having the same error when running
Versions ReportMaster
Minion
I installed via pkng and the latest FreeBSD pkg repo. Geom Disk List
|
Works fine with older version:
Versions ReportMaster
Minion
|
Ok, sorry about this :( it seems there are scenarios where #33604 has a fix to make the data parsing more resilient. @cedwards, could you pull this patch into the port? I polled twitter for more |
Closed via #33604 |
Hey @kev009, After applying this patch I'm still seeing this in a VirtualBox VM: root@:~ # uname -a
FreeBSD 10.2-RELEASE-p18 FreeBSD 10.2-RELEASE-p18 #0: Sat May 28 08:53:43 UTC 2016 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 root@:~ # salt-call --local pkg.latest_version bash
[WARNING ] Failed to open log file, do you have permission to write to /var/log/salt/minion?
[CRITICAL] Failed to load grains defined in grain file disks.disks in function <function disks at 0x80bf9be60>, error:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/salt/loader.py", line 724, in grains
ret = fun()
File "/usr/local/lib/python2.7/site-packages/salt/grains/disks.py", line 31, in disks
return _freebsd_geom()
File "/usr/local/lib/python2.7/site-packages/salt/grains/disks.py", line 118, in _freebsd_geom
parse_geom_attribs(device)
File "/usr/local/lib/python2.7/site-packages/salt/grains/disks.py", line 113, in parse_geom_attribs
if tmp[_geomconsts.ROTATIONRATE] == 0:
KeyError: 'rotationrate'
[INFO ] Executing command ['pkg', 'info', '-ao'] in directory '/root'
[INFO ] Executing command ['pkg', '--version'] in directory '/root'
[INFO ] Executing command ['pkg', 'search', '-S', 'name', '-Q', 'version', '-e', '-q', 'bash'] in directory '/root'
local:
4.3.42_1 root@:~ # geom disk list
Geom name: ada0
Providers:
1. Name: ada0
Mediasize: 22549626880 (21G)
Sectorsize: 512
Mode: r2w2e5
descr: VBOX HARDDISK
ident: VBe248e9aa-bbc8d3a1
fwsectors: 1
fwheads: 1
In all boxes that I have access I do not see the "rotationrate" keyword in the Let me know if you need some testing. Thanks! |
@kev009 / @cachedout Not sure if #33767 sounds good enough but it's not failing anymore for me. Thanks! |
rotationrate will only be there on 10.3 and 11.0 and #33767 is the right intent. Sorry for all the fail around this grain 😞 |
The patch fixes some issues that are new with 2016.3.0 - saltstack/salt#33529 - saltstack/salt#33554 - saltstack/salt#33578 - saltstack/salt#33608 PR: 209829 Submitted by: ohauer, Andreas Montalban <amontalban@gmail.com> Approved by: christer.edwards@gmail.com (maintainer timeout) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@416914 35697150-7ecd-e111-bb59-0022644237b5
The patch fixes some issues that are new with 2016.3.0 - saltstack/salt#33529 - saltstack/salt#33554 - saltstack/salt#33578 - saltstack/salt#33608 PR: 209829 Submitted by: ohauer, Andreas Montalban <amontalban@gmail.com> Approved by: christer.edwards@gmail.com (maintainer timeout)
The patch fixes some issues that are new with 2016.3.0 - saltstack/salt#33529 - saltstack/salt#33554 - saltstack/salt#33578 - saltstack/salt#33608 PR: 209829 Submitted by: ohauer, Andreas Montalban <amontalban@gmail.com> Approved by: christer.edwards@gmail.com (maintainer timeout)
Description of Issue/Question
The following error message is spamming my master log
Setup
happens existing and/or on fresh master without SLS files
Steps to Reproduce Issue
run salt-master on FreeBSD
Versions Report
salt --versions-report
Salt Version:
Salt: 2016.3.0
Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.5.0
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.7
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.11 (default, May 9 2016, 20:02:36)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 15.2.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.3
ZMQ: 4.1.4
System Versions:
dist:
machine: amd64
release: 10.3-RELEASE-p3
system: FreeBSD
version: Not Installed
The text was updated successfully, but these errors were encountered: