Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt-api token expire #35160

Closed
SolarisYan opened this issue Aug 3, 2016 · 4 comments
Closed

salt-api token expire #35160

SolarisYan opened this issue Aug 3, 2016 · 4 comments
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-API severity-critical top severity, seen by most users, serious issues ZD The issue is related to a Zendesk customer support ticket. ZRELEASED - 2018.3.0
Milestone

Comments

@SolarisYan
Copy link
Contributor

Hi there, i use salt-api, first i get a token,and request with the the token.
but if i used the expired token, the request don't have any result, can i set some message to tip the token
have expired?

curl -sSk http://xxx:8000
-H 'Accept: application/x-yaml'
-H 'X-Auth-Token: 1500f41dafb0d1b6e538e1d98324240a0a7beb1e7b35afa6bc60e357913d288a69fdce329e35c26dad38642f1bc8a3f20e36bf8388b6b3101164b59c7f8b583b'
-d client='local'
-d tgt='minion03'
-d fun='test.ping'

i'm sure the token had expired,when i request with it,the request return nothing.

Salt Version:
Salt: 2016.3.1

Dependency Versions:
cffi: Not Installed
cherrypy: 3.2.2
dateutil: Not Installed
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.7.2
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.7
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.5 (default, Nov 20 2015, 02:00:19)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 14.7.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.0.5

System Versions:
dist: centos 7.2.1511 Core
machine: x86_64
release: 3.10.0-327.22.2.el7.x86_64
system: Linux
version: CentOS Linux 7.2.1511 Core

@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 3, 2016

@SolarisYan i think this is a great idea. just to make sure its plausible:

ping @whiteinge do you think this is plausible with salt-api? I'm not certain of its limits or if it is able to parse errors efficiently.

@Ch3LL Ch3LL added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Aug 3, 2016
@Ch3LL Ch3LL added this to the Blocked milestone Aug 3, 2016
@whiteinge
Copy link
Contributor

Salt performs both the authentication and authorization and salt-api only performs a couple light sanity checks. We certainly could add a check to salt-api for this. I think the ideal fix is #6420 but that's a trickier change to make.

@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 16, 2016

Thanks for the input i'll go and approve as a feature request thanks.

@Ch3LL Ch3LL added Feature new functionality including changes to functionality and code refactors, etc. Salt-API RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. and removed Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged labels Aug 16, 2016
@Ch3LL Ch3LL modified the milestones: Approved, Blocked Aug 16, 2016
@rickh563
Copy link

ZD-1488

@rickh563 rickh563 added the ZD The issue is related to a Zendesk customer support ticket. label May 30, 2017
@Ch3LL Ch3LL added severity-critical top severity, seen by most users, serious issues ZRELEASED - 2018.3.0 labels May 31, 2017
@cachedout cachedout removed the severity-critical top severity, seen by most users, serious issues label May 31, 2017
@Ch3LL Ch3LL added severity-critical top severity, seen by most users, serious issues and removed severity-critical top severity, seen by most users, serious issues labels May 31, 2017
@Ch3LL Ch3LL added the severity-critical top severity, seen by most users, serious issues label Jun 14, 2017
@Ch3LL Ch3LL modified the milestones: Approved, oxygen Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-API severity-critical top severity, seen by most users, serious issues ZD The issue is related to a Zendesk customer support ticket. ZRELEASED - 2018.3.0
Projects
None yet
Development

No branches or pull requests

6 participants