Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization support required in ext_pillar http_json modules. #36138

Closed
zhujinhe opened this issue Sep 8, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@zhujinhe
Copy link
Contributor

commented Sep 8, 2016

salt['http.query'] function support lots of parameters via utils/http.py.
However, only 'url' parameter supported in salt/salt/pillar/http_json.py now.
Could we add support for other parameters such as header_dict so that we can do some authorization stuff by:

  ext_pillar:
    - http_json:
        url: http://example.com/api/minion_id
        header_dict: {foo: bar}
        key_foo: value_bar
@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2016

@zhujinhe sounds like a good idea. will approve as a feature request. thanks

@Ch3LL Ch3LL added this to the Approved milestone Sep 8, 2016

@stale

This comment has been minimized.

Copy link

commented Jun 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jun 30, 2018

@stale stale bot closed this Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.