Highstate run with test=True shows changes that need not be made

[stevearc]

Similar to Issues #2815, #1480, and #2353.

I have found that pkgrepo and file.directory display changes on highstate test=True that do not actually need to be made.

The pkgrepo sls file: http://pastebin.com/va6zxeJ4
The output from pkgrepo: http://pastebin.com/gmRuRBrD

The file.directory sls file: http://pastebin.com/jz7vUtgj
The output from file.directory: http://pastebin.com/5JduDTTi

Ubuntu 12.04
Salt 0.13.1

[thatch45]

Thanks, should be easy to get fixed

[thatch45]

Ok, I got the file error here, but not the but not the pkg one yet, there seems to be an error in listing the present repos and matching to them in the apt execution module, looks like @morganfainberg wrote this code, just looks like a case is being missed.

[tempusfrangit]

@stevearc Is this still an issue with #4120 merged in (regarding the apt source issue). I know where there could be an error, but there was some changes to the matching done in the last round of PPA/Apt Sources updates.

@thatch45 I'll poke at the apt part a bit more when I have a few cycles to spare.

[thatch45]

I am closing this out, since the changes in #4120 logically repair it, please reopen if the problem persists. This was the last on the list of bad test=True erorrs

[stevearc]

I just tried it again with the develop branch and had more problems. The pkgrepo with test=True is unchanged, and now I'm seeing an exception for file.directory.

sls file: http://pastebin.com/30HnReFE
output: http://pastebin.com/T3Dxz7t2

Ubuntu 12.04
salt 0.13.0-927-g36ac148

[thatch45]

I will get the file.directory fixed

[thatch45]

10799d7
should fix the file.directory issue

[stevearc]

file.directory exception is fixed, but both file.directory and pkg.pkgrepo are still printing changes that will not be made on a highstate.

[thatch45]

Ok, I am going to push this to 0.15.0 to clean up the repo returns

[tempusfrangit]

@thatch45 @stevearc I see what is happening here (wrt the repo returns). There needs to be some sanitization of the comparison between repo (returned values that are in the apt.sources) and the passed in 'repokwargs' as some of the args are needed to perform actions (add keys, et. al) and this data is never actually reflected in the object (it can't be as it doesn't exist in the actual source definition line in sources.list unlike, say RPM repositories).

[thatch45]

@morganfainberg did your recent pull reqs fix this one?

[tempusfrangit]

@thatch45 whoa, missed this. yes the pull reqs should have solved this.