New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase checksums are not accepted by archive.extracted #38914

Closed
hgfischer opened this Issue Jan 24, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@hgfischer
Contributor

hgfischer commented Jan 24, 2017

Uppercase checksums are not accepted by archive.extracted

Setup

Use archive.extracted with any tarball and with an uppercase source_hash. I tested with MD5.

Steps to Reproduce Issue

 Comment: Specified md5 checksum for /var/cache/salt/minion/files/dev/_repos_dist_release_kafka_0.10.1.1_kafka_2.11-0.10.1.1.tgz (C32C75FF9B23CD6B64717F9EB5B4EB87) does not match actual checksum (c32c75ff9b23cd6b64717f9eb5b4eb87)

Versions Report

Salt Version:
Salt: 2016.11.1

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.4.2
gitdb: 0.6.4
gitpython: 1.0.1
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: 1.0.3
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 15.2.0
RAET: Not Installed
smmap: 0.9.0
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.1.4

System Versions:
dist: Ubuntu 16.04 xenial
machine: x86_64
release: 4.8.0-32-generic
system: Linux
version: Ubuntu 16.04 xenial

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jan 25, 2017

It would be easy to just pass in the lower version of the string, but I have marked it as a bug and low hanging fruit for someone to take care of.

It looks like this comparison is actually inside of the salt.modules.file execution module.

Thanks
Daniel

@hgfischer

This comment has been minimized.

Contributor

hgfischer commented Jan 25, 2017

Yes, that's what I did to not be blocked.

And yes, it is a bug, because any hexadecimal number is case insensitive.

@lordcirth

This comment has been minimized.

Contributor

lordcirth commented Apr 20, 2017

This bug has been fixed in #40754

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Apr 20, 2017

Thanks!

@gtmanfred gtmanfred closed this Apr 20, 2017

rallytime added a commit to rallytime/salt that referenced this issue Jul 3, 2018

Add regression test for Issue saltstack#48230
This also tests the fix for issue saltstack#38914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment