Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[FEATURE] Allow source parameter to specify a location on the minion in file.* state modules #4292

Open
czee opened this Issue · 9 comments

4 participants

@czee

Currently the source parameter allows 'salt://', 'http://' and 'ftp://'. This issue requests the ability to simply use 'file://' such as:

/etc/pkg/pkg.conf:
  file.managed:
    - source: file///etc/pkg/pkg.conf.orig
    - user: root
    - group: root
    - mode: 0660
@SEJeff
Owner

That would be kind of nice for file.recurse /etc/skel or something to that effect.

@czee

Also for instances where you may want to copy over a configuration file.

/etc/apache2/sites-available/munin:
  file.managed:
    - source: file:///etc/munin/apache.conf
    - user: root
    - group: root
    - mode: 0644
@thatch45
Owner

I THINK this should be easy to add, I will see :)

@czee

@thatch45, upon reviewing this issue again it seems it might be harder than you think. Some modules in salt are depending on certain protocols. Something like this:

+    if requirements and requirements.startswith('salt://'):
@thatch45
Owner

We need to put file:// as a valid proto into the cp.get_file routines and then just make these like things run salt.utils.valid_proto instead :)

@czee

Dead?

@thatch45
Owner

What do you mean by dead?
We have a lot of feature requests and issues and not everything can be added immediately

@czee

Sorry I didn't mean to pry, it's just that I thought you said it was an easy feature to add and a month had passed so I assumed it had been forgotten.

@thatch45
Owner

Sorry If I came across too sharply, this is goign to take a little more time and I moved it to the 0.16.0 milestone

@basepi basepi modified the milestone: Helium, Hydrogen Release
@basepi basepi modified the milestone: Approved, Helium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.