salt 0.14.0 puppet module won't work with puppet enterprise #4307

Closed
aboe76 opened this Issue Mar 28, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@aboe76
Contributor

aboe76 commented Mar 28, 2013

I found an issue with salt/module/puppet.py
It won't work if puppet enterprise is installed, because puppet enterprise is configured differently

Issue:
line 60 and 61:

self.vardir = '/var/lib/puppet'
self.confdir = '/etc/puppet'

This values are only for puppet opensource not for puppet enterprise:
For puppet enterprise it should be:

self.vardir = '/var/opt/lib/pe-puppet' 
self.confdir = '/etc/puppetlabs/puppet' 

If these could be refactored as defines like the one in rabbitmq.py
and only called when added to the salt puppet.cmd it would enable
puppet enterprise support

Or these could be dynamic with:
puppet agent --configprint vardir
puppet agent --configprint confdir

I'm willing to test the new module in our test environment:
sles 11 sp2 master
sles 11 sp2 minion

both build from same template with latest puppet enterprise version

@aboe76

This comment has been minimized.

Show comment Hide comment
@aboe76

aboe76 Apr 3, 2013

Contributor

fix implemented and tested.

Contributor

aboe76 commented Apr 3, 2013

fix implemented and tested.

@aboe76 aboe76 closed this Apr 3, 2013

@UtahDave

This comment has been minimized.

Show comment Hide comment
@UtahDave

UtahDave Apr 3, 2013

Member

Thanks for testing that @aboe76 . It would have taken a long time for me to get a testing environment going.

Member

UtahDave commented Apr 3, 2013

Thanks for testing that @aboe76 . It would have taken a long time for me to get a testing environment going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment