-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading Salt via Salt results in dying minions and broken dpkg #43340
Comments
I have replicated this issue. @terminalmage shouldn't this have been solved by using @syphernl a quick fix is to add Thanks, |
@gtmanfred Using |
@gtmanfred Using |
It appears that there are multiple PRs and bugs that either add or remove KillMode settings from all unit files, while we want to keep it for Please see #33792 for a discussion concerning the salt-master and #29295 for the one concerning salt-minion. #36806 is the one that triggered this round of removal. |
This particular bug has been haunting me ever since I started deploying xenial servers. |
The same thing is happening again with the upgrade of 2017.7.2:
|
@terminalmage mind taking a look at this for 2017.7.3 release? |
@rallytime Seems like this is still an issue with 2017.7.3. Our minions died after an upgrade and required manual intervention to come back up. |
I can confirm this. 2017.7.3 craps out on Ubuntu 16.04 and Debian 8+9, again... :( |
I am testing on debian 9, and I am unable to replicate this.
Can you provide the output you were seeing during the upgrade in the minion logs? Thanks, |
|
Here is my whole trace log of it working https://gist.github.com/gtmanfred/0719ca5c4fac2b3a67cfcddf61bfb3a6 unfortunately i still cannot replicate this If you have a machine that is still on 2017.7.2 on can you open /usr/lib/python2.7/dist-packages/salt/modules/aptpkg.py and add
And then restart the salt-minion and run the upgrade? Thanks, |
Hi, strange behavior:
BUT, the update did finish successfully and the minion is running!
|
What is in the /var/log/salt/minion debug log when you have that use_vt enabled? it should show all the apt-get output in there Daniel |
It looks like this (but that was the half way successful update):
|
Ok, i have been able to replicate that, the problem is the fact that the This should be fully fixed with the next upgrade, but I will make sure that it gets tested and is verified that it will work starting with 2017.7.4 Thanks, |
I have confirmed that the upgrade to 2017.7.4 goes smoothly using our staging repository.
|
I deployed the following before the upgrade, which allowed for a smooth one:
|
Description of Issue/Question
We use
pkg.upgrade dist_upgrade=True
to upgrade our servers semi-unattended.They were running 2017.7.0 prior to issuing the upgrade command and were supposed to be upgraded to 2017.7.1.
However, a majority of the machines had issues where the
salt-minion
would not be running anymore afterwards and shows the following issue when doing anything withapt
afterwards on the machine itself:Doing so shows the following issue:
After running the commands above, this
ISTM that this issue may be caused by the fact that the systemd config has changed, since it seems to only affect our Ubuntu 16.04 machines and works fine on 14.04.
Versions Report
The text was updated successfully, but these errors were encountered: