New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some states incorrectly return None instead of an empty dict when there are no changes #47059

Closed
OrlandoArcapix opened this Issue Apr 13, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@OrlandoArcapix
Contributor

OrlandoArcapix commented Apr 13, 2018

Description of Issue/Question

Version 2018.3.0 fails state runs when no changes are made with modules which return "None" instead of an empty dict for the 'changes' data.

See ticket #46985

Steps to Reproduce Issue

See the following lines in files in salt/states/:

boto_cfn.py:        ret['changes'] = None
boto_cfn.py:        ret['changes'] = None
boto_cfn.py:        ret['changes'] = None
boto_iam.py:    ret['changes'] = None
boto_iot.py:            ret['changes'] = None
glassfish.py:            ret['changes'] = None
glassfish.py:            ret['changes'] = None
glassfish.py:        ret['changes'] = None
grafana_datasource.py:            ret['changes'] = None
influxdb_user.py:                ret['changes'] = None
vault.py:        ret['changes'] = None
zenoss.py:        ret['changes'] = None
zenoss.py:        ret['changes'] = None
@OrlandoArcapix

This comment has been minimized.

Contributor

OrlandoArcapix commented Apr 13, 2018

Hey @rallytime - I've put in a PR against issue #47059, which replaces those None entries with an empty dict{}m though I've not been able to test as I don't have an environment which uses the state modules I've updated in that pull request.

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 13, 2018

Awesome! Thanks @OrlandoArcapix! Let's see how the test run goes on that. Thanks for filing this issue and for the fix. :)

@rallytime

This comment has been minimized.

Contributor

rallytime commented Apr 25, 2018

Closed via #47060

@rallytime rallytime closed this Apr 25, 2018

bbinet added a commit to bbinet/salt that referenced this issue Jul 20, 2018

bbinet added a commit to bbinet/salt that referenced this issue Jul 20, 2018

cro added a commit to cro/salt that referenced this issue Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment