Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow root volume tagging (aws ec2) in cloud map for salt-cloud #47097

Closed
thetoolsmith opened this issue Apr 16, 2018 · 3 comments
Closed

allow root volume tagging (aws ec2) in cloud map for salt-cloud #47097

thetoolsmith opened this issue Apr 16, 2018 · 3 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc. stale
Milestone

Comments

@thetoolsmith
Copy link
Contributor

Volume tagging can be set in cloud map as implemented in this change: #18451

However, tagging of root volume in the cloud map is not possible.
I have tried a couple of different tests.

  1. duplicate the block_device_mappings volume config in the volumes: {} block. This creates two volumes and fails to attach one.
  2. add tagging directly to the block_device_mappings block, no success here either.

In our automation we have to get return metadata from AWS, do an instance/root vol lookup and then add a tag. This is a lot of extra code to workaround.

@gtmanfred gtmanfred added the Feature new functionality including changes to functionality and code refactors, etc. label Apr 16, 2018
@gtmanfred gtmanfred added this to the Approved milestone Apr 16, 2018
@gtmanfred
Copy link
Contributor

I am marking this as a feature request.

Daniel

@thetoolsmith
Copy link
Contributor Author

thank you.

@stale
Copy link

stale bot commented Sep 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Sep 6, 2019
@stale stale bot closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. stale
Projects
None yet
Development

No branches or pull requests

2 participants