New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017.7.5 zpool.present does not check for properties=None before attempting to enumerate properties #47696

Closed
darkpixel opened this Issue May 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@darkpixel
Contributor

darkpixel commented May 17, 2018

#37932 is not fixed in 2017.7.5

The zpool state still attempts to enumerate the contents of 'properties' when properties is None throwing a TypeError: 'NoneType' object is not iterable

for prop in properties:

It is fixed in 2018. Can the fix be backported?

if properties:

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 17, 2018

Unfortunately there was a huge change between 2017.7 and 2018.3, so it can't be easily backported.

3f30ab2#diff-817aa4ecf848121d64232f521f7894bbR268

If you wanted to submit a smaller change just to fix this issue, we would be more than happy to include it in 2017.7, just open a PR against the 2017.7 branch.

Thanks!
Daniel

@gtmanfred gtmanfred added this to the Approved milestone May 17, 2018

rallytime added a commit that referenced this issue May 18, 2018

Merge pull request #47708 from darkpixel/47696-do-not-enumerate-none
Wrap properties loop with a check for None.  Closes GH-47696

@rallytime rallytime closed this in 041e4c6 May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment