New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch.index_template_present state with check_definition: True fails. #47701

Closed
babs opened this Issue May 17, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@babs
Contributor

babs commented May 17, 2018

Description of Issue/Question

elasticsearch.index_template_present state with check_definition: True fails.
Also diff considers different while semantically the same.

[PR for is comming for both]

          ID: default_refresh_interval
    Function: elasticsearch.index_template_present
      Result: False
     Comment: expected string or buffer
     Started: 14:49:30.124598
    Duration: 4.483 ms
     Changes:   

Setup

default_refresh_interval:
  elasticsearch.index_template_present:
    - check_definition: True
    - definition:
        index_patterns:
          - "*"
        order: 1
        settings:
          index:
            refresh_interval: 30s

Steps to Reproduce Issue

(Include debug logs if possible and relevant.)

Versions Report

Salt Version:
           Salt: 2018.3.0
 
Dependency Versions:
           cffi: Not Installed
       cherrypy: unknown
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: 2.0.0
      gitpython: 2.1.1
          ioflo: Not Installed
         Jinja2: 2.9.4
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Nov 24 2017, 17:33:09)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: 2.0.1
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1
 
System Versions:
           dist: debian 9.4 
         locale: UTF-8
        machine: x86_64
        release: 4.9.0-4-amd64
         system: Linux
        version: debian 9.4 

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented May 17, 2018

Thanks for the PR to fix this!
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment