New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for custom returners used for master job cache #48306

Closed
davidscholberg opened this Issue Jun 26, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@davidscholberg

davidscholberg commented Jun 26, 2018

Description of Issue/Question

The documentation for master job cache support for returners needs a couple updates:

  1. The salt.utils.jid.gen_jid function now requires the salt config object (e.g. __opt__) as an argument.
  2. The save_load function now requires a third argument: minions.

Setup

N/A

Steps to Reproduce Issue

N/A

Versions Report

           Salt: 2018.3.1

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: 2.0.0
      gitpython: 2.1.1
          ioflo: Not Installed
         Jinja2: 2.9.4
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: 1.3.7
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Nov 24 2017, 17:33:09)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: 2.0.1
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1

System Versions:
           dist: debian 9.4
         locale: UTF-8
        machine: x86_64
        release: 4.9.0-6-amd64
         system: Linux
        version: debian 9.4
@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 26, 2018

Fixed by #48319

@gtmanfred gtmanfred closed this Jun 26, 2018

@gtmanfred gtmanfred added the Bug label Jun 26, 2018

@gtmanfred gtmanfred added this to the Approved milestone Jun 26, 2018

@davidscholberg

This comment has been minimized.

davidscholberg commented Jun 26, 2018

@gtmanfred It seems like #48319 addresses the gen_idfunction, but what about the save_load function I mentioned above?

@gtmanfred gtmanfred reopened this Jun 26, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jun 26, 2018

save_load added to that.

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 6, 2018

save_load has actually been passing the minions key since 2015.8.

https://github.com/saltstack/salt/blob/2015.8/salt/master.py#L2163

@davidscholberg

This comment has been minimized.

davidscholberg commented Jul 7, 2018

Right, we're updating a master from version 2015.5.3 🙁

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 7, 2018

This was listed in the release notes for 2015.8. but I have gone ahead and updated the returner docs as well.

@rallytime rallytime closed this Aug 6, 2018

@rallytime

This comment has been minimized.

Contributor

rallytime commented Aug 6, 2018

Fix was merged and will be available in 2018.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment