New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link in Docs #48818

Closed
guettli opened this Issue Jul 30, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@guettli
Contributor

guettli commented Jul 30, 2018

Description of Issue/Question

on this page https://docs.saltstack.com/en/latest/ref/states/all/salt.states.pkg.html#salt.states.pkg.removed

The link to "pkg.removed" links to "pkg.installed". Same for "pkg.purged".

@4815162342lost

This comment has been minimized.

4815162342lost commented Jul 30, 2018

All fine for me.

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 30, 2018

I am unable to replicate this. It is going to the link id anchor correctly.

@gtmanfred gtmanfred added this to the Blocked milestone Jul 30, 2018

@guettli

This comment has been minimized.

Contributor

guettli commented Jul 31, 2018

I talk about this line:

In version 2015.8.9, an ignore_epoch argument has been added to pkg.installed, pkg.removed, and pkg.purged states

"pkg.removed" links to "pkg.installed"

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 31, 2018

Yup, it looks like it just needs to be fixed on those lines.

https://github.com/saltstack/salt/blob/2017.7/salt/states/pkg.py#L978

Thanks.
Daniel

@gtmanfred gtmanfred modified the milestones: Blocked, Approved Jul 31, 2018

gtmanfred added a commit to gtmanfred/salt that referenced this issue Jul 31, 2018

gtmanfred added a commit to gtmanfred/salt that referenced this issue Jul 31, 2018

@gtmanfred

This comment has been minimized.

Contributor

gtmanfred commented Jul 31, 2018

Fixed pending #48840

@rallytime rallytime closed this Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment