New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows packages are hidden in pkg.list_pkgs if they have no DisplayVersion #48865

Open
mts-avco opened this Issue Aug 1, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mts-avco

mts-avco commented Aug 1, 2018

Description of Issue/Question

Entries in Add/Remove Programs that have no DisplayVersion are not included in the package list returned by pkg.list_pkgs. Attempts to install such software using pkg.install result in the install reporting as failed, even though it actually succeeded

Setup

First noticed with MS SQL Server Express 2017. Any uninstall entry without DisplayVersion will trigger this problem, so creating a fake one would be just as effective as removing (or renaming) DisplayVersion from a valid entry.

Steps to Reproduce Issue

Run pkg.list_pkgs and any entries without a version will not be included. Add DisplayVersion manually and they appear.

Versions Report

           Salt: 2018.3.2

Dependency Versions:
           cffi: 1.10.0
       cherrypy: 10.2.1
       dateutil: 2.6.1
      docker-py: Not Installed
          gitdb: 2.0.3
      gitpython: 2.1.3
          ioflo: Not Installed
         Jinja2: 2.9.6
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.6
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: 2.17
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:25:58) [MSC v.1500 64 bit (AMD64)]
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 16.0.3
           RAET: Not Installed
          smmap: 2.0.3
        timelib: 0.2.4
        Tornado: 4.5.1
            ZMQ: 4.1.6

System Versions:
           dist:
         locale: cp1252
        machine: AMD64
        release: 2016Server
         system: Windows
        version: 2016Server 10.0.14393  Multiprocessor Free
@mts-avco

This comment has been minimized.

mts-avco commented Aug 1, 2018

@mts-avco

This comment has been minimized.

mts-avco commented Aug 1, 2018

Also confirmed as not working on the same minion after installing salt-minion 2018.3.2 (py3)

@mts-avco

This comment has been minimized.

mts-avco commented Aug 2, 2018

Commenting out the if block that results in return around win_pkg.py:464 appears to fix this, as suggested by @damon-atkins on slack yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment