New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MasterPillarUtil tests #49018

Closed
Ch3LL opened this Issue Aug 8, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented Aug 8, 2018

Add tests for the masterpillarutil class in salt/utils/master.py

@Ch3LL Ch3LL added the Fluorine label Aug 8, 2018

@Ch3LL Ch3LL added this to the Approved milestone Aug 8, 2018

@garethgreenaway

This comment has been minimized.

Member

garethgreenaway commented Aug 9, 2018

@rallytime @Ch3LL The cache runner has three functions (grains, pillar, & mine) which use the corresponding functions in MasterPillarUtil, testing these as part of the cache runner tests seems like a good approach to testing MasterPillarUtil. Thoughts?

@rallytime

This comment has been minimized.

Contributor

rallytime commented Aug 9, 2018

Yeah, I think that sounds like a good approach.

Some unit tests might be good as well where you think appropriate. After a quick glance, maybe some of those helper functions could use some unit tests since those seem to be doing most of the logical heavy lifting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment