Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect default value of minion's 'ipv6' option #49159

Closed
wenxin-wang opened this issue Aug 16, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@wenxin-wang
Copy link

commented Aug 16, 2018

Description of Issue/Question

In the documentation of the latest version(2018.3.2), and the develop version, the default value of minion's ipv6 option is documented as None.

However, in the code of 2018.3.2 and the develop branch, the default value is coded as False.

This makes IPv6-only minion still use master's IPv4 address when using a domain name. To work around this issue currently, set an empty ipv6 option in /etc/salt/minion:

ipv6:

This sets opts['ipv6'] in the code to None, and now the minion respects the preference of the OS.

Steps to Reproduce Issue

  1. Disable IPv4 on the minion
  2. Do not set ipv6 in the minion config
  3. Use domain name for master, and make sure it has AAAA record
  4. run salt-minion -l debug. The minion will try to connect to the master using IPv4 address, over and over again.

Versions Report

Salt Version:
Salt: 2018.3.2

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.5.3
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.8
mysql-python: 1.3.7
pycparser: Not Installed
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.13 (default, Nov 24 2017, 17:33:09)
python-gnupg: Not Installed
PyYAML: 3.12
PyZMQ: 16.0.2
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.4.3
ZMQ: 4.2.1

System Versions:
dist: debian 9.4
locale: UTF-8
machine: armv7l
release: 4.14.50-v7+
system: Linux
version: debian 9.4

@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2018

looks like the ipv6 default value was changed to false here: ccfa242 which is in this PR #45354

ping @terminalmage any possibilities we can change it back to None and avoid the warning?

@terminalmage

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

Good catch, since I don't recall the reasoning for changing that, I've reverted it in #49263 and set it so that None will not cause a warning when this value is set to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.