Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Suppress a configurable domain in the generated minion_id #49212

Closed
marbx opened this issue Aug 20, 2018 · 6 comments
Closed

Feature: Suppress a configurable domain in the generated minion_id #49212

marbx opened this issue Aug 20, 2018 · 6 comments
Labels
Feature
Milestone

Comments

@marbx
Copy link
Contributor

@marbx marbx commented Aug 20, 2018

Proposal

When the salt minion lacks an id, utils.network.generate_minion_id() generates a fully qualified domain name, using a variety of sources.

I propose a new setting minion_id_generate_no_domain, to suppresses a single domain in the result of above function.

Current Behavior

The function returns king_bob.foo.bar

Proposed behavior:

Without minion_id_generate_no_domain , as currently.
With minion_id_generate_no_domain = foo.baz, as currently
With minion_id_generate_no_domain = foo.bar, the function returns king_bob

marbx added a commit to marbx/salt that referenced this issue Aug 20, 2018
marbx added a commit to marbx/salt that referenced this issue Aug 20, 2018
@Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Aug 21, 2018

thanks for the PR!! As the pr resolves this issue I will close but please let me know if it needs to be reopened :)

@Ch3LL Ch3LL closed this Aug 21, 2018
@Ch3LL Ch3LL added Feature team-core labels Aug 21, 2018
@Ch3LL Ch3LL added this to the Approved milestone Aug 21, 2018
@marbx marbx changed the title Feature: Suppress a configurable domain in utils.network._generate_minion_id() Feature: Suppress a configurable domain in salt.config.__init__ Aug 21, 2018
@marbx marbx changed the title Feature: Suppress a configurable domain in salt.config.__init__ Feature: Suppress a configurable domain in generated the minion_id Aug 21, 2018
@marbx marbx changed the title Feature: Suppress a configurable domain in generated the minion_id Feature: Suppress a configurable domain in the generated the minion_id Aug 21, 2018
@marbx
Copy link
Contributor Author

@marbx marbx commented Aug 21, 2018

thank you, @Ch3LL

@marbx marbx changed the title Feature: Suppress a configurable domain in the generated the minion_id Feature: Suppress a configurable domain in the generated minion_id Aug 21, 2018
marbx added a commit to marbx/salt that referenced this issue Aug 21, 2018
marbx added a commit to marbx/salt that referenced this issue Aug 21, 2018
@marbx
Copy link
Contributor Author

@marbx marbx commented Sep 6, 2018

@Ch3LL, could you please help me with PR #49378
Which are the requested changes?

@marbx
Copy link
Contributor Author

@marbx marbx commented Sep 7, 2018

Hi @Ch3LL, I think the requested changes are from terminalmage, I asked him.

@Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Sep 7, 2018

glad you got it figured out. let me know if can help with anything else :)

@marbx
Copy link
Contributor Author

@marbx marbx commented Sep 7, 2018

Yep, and terminalmarge already explained his request in all details.

Thank you for the offer.

I just looked at your PR #48866.
I will come back to twangboy and might come back to you because I would like that Jenkins creates the Windows msi installer.

First I need to verify the installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature
Projects
None yet
Development

No branches or pull requests

2 participants