Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
When the salt minion lacks an id, utils.network.generate_minion_id() generates a fully qualified domain name, using a variety of sources.
I propose a new setting minion_id_generate_no_domain, to suppresses a single domain in the result of above function.
The function returns king_bob.foo.bar
Without minion_id_generate_no_domain , as currently.
With minion_id_generate_no_domain = foo.baz, as currently
With minion_id_generate_no_domain = foo.bar, the function returns king_bob
minion_id_generate_no_domain = foo.baz
minion_id_generate_no_domain = foo.bar
The text was updated successfully, but these errors were encountered:
thanks for the PR!! As the pr resolves this issue I will close but please let me know if it needs to be reopened :)
Sorry, something went wrong.
thank you, @Ch3LL
@Ch3LL, could you please help me with PR #49378
Which are the requested changes?
Hi @Ch3LL, I think the requested changes are from terminalmage, I asked him.
glad you got it figured out. let me know if can help with anything else :)
Yep, and terminalmarge already explained his request in all details.
Thank you for the offer.
I just looked at your PR #48866.
I will come back to twangboy and might come back to you because I would like that Jenkins creates the Windows msi installer.
First I need to verify the installer.
No branches or pull requests