Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Virtual grain in Windows #50015
Hi there, we check if our hosts are virtual as such in our pillars:
and we have a problem on Windows where a physical host won't have a grain key for virtual and jinja errors out, because in grains/core.py the windows grain defaults to an empty dictionary rather than ''physical":
We worked around that creating a custom grain 'is_virtual' and wrapping around virtual as such:
But shouldn't the windows "virtual" default to "pyhisical" after the os check like this?
We are on 2017.7.7 but I can see the code is the same in the newer versions,
That seems reasonable to me.
Would you mind submitting a pr to the 2017.7 branch to fix this?