Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport runtests.py's --from-filenames functionality to 2018.3 branch #50050

Closed
terminalmage opened this issue Oct 15, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Oct 15, 2018

Once we have --from-filenames working in develop, we need to backport several PRs to 2018.3 so that 2018.3 and fluorine can use this functionality.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

OK, so in PR #50182 there were 3 test files back-ported for files that don't exist in 2018.3.

The following test files were removed:

  • unit/beacons/test_smartos_imgadm.py
  • unit/beacons/test_smartos_vmadm.py
  • unit/beacons/test_watchdog.py
  • Relevant commit for those changes ^: dfa05b9

All three of the associated beacons exist in fluorine, so after #50182 is merged forward to fluorine, the test files will need to be added again to the fluorine branch.

The following commits should be reverted on the merge-forward:

This is because some of the tests in the develop branch are not relevant in 2018.3. We need to remove them for 2018.3, but they are relevant to fluorine and need to be added back in.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

#50230 needs to be back-ported as well, once it's merged.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

OK, I did all of the clean up mentioned in my comments above, so this is nearly done.

Unfortunately, it appears that once I merged in #50182, some branch tests started failing on 2018.3. I will need to investigate that first thing in the morning.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

Those test failures should be resolved with #50308

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

All of the work here should be done now. Closing!

@rallytime rallytime closed this Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.