Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
max_event_size does not always trim large events. #50062
Description of Issue/Question
max_event_size Does not always trim long events.
If the event has a
However just serializing that dict and running the trim on it also doesn't seem like the right answer as that could be trimming important information used for parsing the event data.
I'm not sure what the correct course is for this. But I can see this causing headaches for very large state runs.
Reducing this down to a more simple test can be done with the following.
create 2 largeish random files and convert them to base64 so that we don't trigger diff binary mode.
then alternate between these 2 states.
This will create a huge return dict inside the return data. which will get sent back to the master as an job event will not be trimmed by dict_trim.
Steps to Reproduce Issue
although dict_trim really hasn't changed since 2016 so this should happen in all versions since then.
Made some progress on this one today, here is a preview from the salt event runner: