Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowpkg.diff refers to a package name, but a package file is required #50097

Closed
aplanas opened this issue Oct 17, 2018 · 3 comments

Comments

@aplanas
Copy link
Contributor

commented Oct 17, 2018

Description of Issue/Question

lowpkg.diff (rpm.py) have a parameter named package that refers to a package name (apache2, xz, etc), but internally is using rpm2cpio to see the content of the package. The problem is that this command requite a RPM file.

This can be a documentation issue, that affect the examples and all system dependent package managers too.

If is a documentation issue I can fix it, but first I would like to have a confirmation that the expectations are not wrong.

Versions Report

develop branch

@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2018

ping @isbm looks like you add this here: #21769

mind answering @aplanas 's concerns

@Ch3LL Ch3LL added this to the Blocked milestone Oct 18, 2018
@isbm

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2018

@aplanas yeah, the diff would require downloaded file. Because you would need to diff with something, right? 😉

@aplanas

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2018

Ok, fixing this

aplanas added a commit to aplanas/salt that referenced this issue Oct 19, 2018
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097
aplanas added a commit to aplanas/salt that referenced this issue Oct 30, 2018
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097
aplanas added a commit to aplanas/salt that referenced this issue Oct 30, 2018
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097
aplanas added a commit to aplanas/salt that referenced this issue Oct 31, 2018
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097
aplanas added a commit to aplanas/salt that referenced this issue Nov 5, 2018
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097
aplanas added a commit to aplanas/salt that referenced this issue Jan 30, 2019
Package names are useless for lowpkg.diff, as to make a full
comparison we need to access the RPM

Fix saltstack#50097

(cherry picked from commit 5484791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.