Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme.cert falsely reports changes #50310

Closed
xuhcc opened this issue Oct 30, 2018 · 1 comment

Comments

@xuhcc
Copy link
Contributor

commented Oct 30, 2018

Description of Issue

After upgrading from 2018.3.2 to 2018.3.3 execution of salt.states.acme.cert with renew parameter always reports changes, even if certificate is not changed:

          ID: my_cert
    Function: acme.cert
        Name: domain.tld
      Result: True
     Comment: Certificate /etc/letsencrypt/live/***/cert.pem unchanged
     Started: 17:38:31.068335
    Duration: 6203.158 ms
     Changes:   
              ----------
              new:
                  ----------
                  ...
                  not_after:
                      1548367725
                  not_before:
                      1540591725
                  ...
              old:
                  ----------
                  ...
                  not_after:
                      1548367725
                  not_before:
                      1540591725
                  ...

Summary for my-server
--------------
Succeeded: ... (changed=1)

Setup

my_cert:
  acme.cert:
    - name: domain.tld
    - email: mail@example.com
    - webroot: /var/lib/letsencrypt/
    - renew: 20

Versions Report

$ salt-ssh --versions-report
Salt Version:
           Salt: 2018.3.3
 
Dependency Versions:
           cffi: 1.11.5
       cherrypy: Not Installed
       dateutil: 2.7.3
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: 0.30.1
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.19
       pycrypto: 3.6.6
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.15 (default, Jun 27 2018, 13:05:28)
   python-gnupg: Not Installed
         PyYAML: 3.13
          PyZMQ: 17.1.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 5.1.1
            ZMQ: 4.2.5
 
System Versions:
           dist:   
         locale: UTF-8
        machine: x86_64
        release: 4.18.16-arch1-1-ARCH
         system: Linux
        version: Not Installed
@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

This is the only PR that affects the acme modules between those two releases: #48635

ping @nbraud can you take a look here

@Ch3LL Ch3LL added Bug Pending Discussion and removed Bug labels Oct 31, 2018
@Ch3LL Ch3LL added this to the Blocked milestone Oct 31, 2018
xuhcc added a commit to xuhcc/salt that referenced this issue Nov 6, 2018
xuhcc added a commit to xuhcc/salt that referenced this issue Nov 6, 2018
@cachedout cachedout closed this in 9440794 Nov 6, 2018
Ch3LL added a commit to Ch3LL/salt that referenced this issue May 2, 2019
Ch3LL added a commit to Ch3LL/salt that referenced this issue May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.