Resolves issue 50253 -- sdb yaml bug found when opening the yaml file to read values in#50436
Closed
klafkoff wants to merge 4 commits into
Closed
Resolves issue 50253 -- sdb yaml bug found when opening the yaml file to read values in#50436klafkoff wants to merge 4 commits into
klafkoff wants to merge 4 commits into
Conversation
klafkoff
changed the title
dwoz
reviewed
Nov 12, 2018
Contributor
Contributor
|
Bump @klafkoff |
Contributor
|
We didn't get a response here so I am closing this. If the submitter comes back and leaves a comment here, we can easily re-open it. |
Author
|
I was AFK, new commit PR shortly using kwargs. Digging through the unit/integration tests to see how to write a regression test as mentioned by @dwoz |
|
2018.3.3 & 2018.3.4 suffers from this annoying problem. |
Contributor
|
@klafkoff Do you have a status on this? |
|
@klafkoff |
Contributor
|
@klafkoff This PR seems to have gone stale so I am going to close it for now. Please feel free to submit another PR with these changes if you have a chance to resolve the conflicts and address the other concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue #50253
What issues does this PR fix or reference?
#50253
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.