Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a long description to setup.py for the new pypi.org #50964

Closed
gtmanfred opened this issue Dec 21, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@gtmanfred
Copy link
Contributor

commented Dec 21, 2018

Description of Issue/Question

Since the upgrade of pypi.org, there is no project description for salt.

The long_description needs to be set on the sdist for this to be displayed on https://pypi.org/project/salt

See https://github.com/saltstack/pepper/blob/develop/setup.py#L17-L18 for an example

@dwoz

This comment has been minimized.

Copy link
Contributor

commented Dec 26, 2018

@gtmanfred Thanks for pointing this out. :)

@dwoz dwoz added this to the Approved milestone Dec 26, 2018

waynew added a commit to waynew/salt that referenced this issue Jan 2, 2019

Set long_description
It's good to have information on PyPI if people are looking there.

---

Closes saltstack#50964

Signed-off-by: Wayne Werner <wwerner@saltstack.com>

garethgreenaway added a commit to garethgreenaway/salt that referenced this issue Jan 3, 2019

Set long_description
It's good to have information on PyPI if people are looking there.

---

Closes saltstack#50964

Signed-off-by: Wayne Werner <wwerner@saltstack.com>
@ezh

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

@garethgreenaway I have the next error after this patch

Traceback (most recent call last):
  File "setup.py", line 1253, in <module>
    setup(distclass=SaltDistribution)
  File "/opt/saltstack/lib/python3.6/distutils/core.py", line 108, in setup
    _setup_distribution = dist = klass(attrs)
  File "setup.py", line 878, in __init__
    self.long_description = f.read()
  File "/opt/saltstack/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 67: ordinal not in range(128)
@waynew

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

@ezh What is your LANG and LC_ALL environment variables?

@waynew

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

@ezh I added a PR, let me know if that solves your issue!

@ezh

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

I haven't LANG and LC_ALL at all. It is a Docker build environment.

Step 10/56 : RUN env
 ---> Running in 724755cd24f1
HOSTNAME=724755cd24f1
SALT_COMMIT=develop
TARGET=/opt/saltstack
HOME=/root
SALT_BRANCH=develop
PATH=/opt/saltstack/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
DEBIAN_FRONTEND=noninteractive
GOSU_VERSION=1.10
PWD=/
@waynew

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

@ezh Could you share your Dockerfile? If not, at least the base image that you're using would be helpful.

@ezh

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

I'm sure that I could share 1st part of it.

FROM debian:9-slim

MAINTAINER Alexey Aksenov <ezh@ezh.msk.ru>

ARG GOSU_VERSION=1.10
ARG SALT_BRANCH=develop
ARG SALT_COMMIT=develop
ARG TARGET=/opt/saltstack
ENV TARGET=$TARGET
ENV DEBIAN_FRONTEND noninteractive
ENV PATH /opt/saltstack/bin:$PATH

RUN echo Install SaltStack $SALT_BRANCH to $TARGET location
RUN mkdir -p ${TARGET}
RUN apt-get update && apt-get install -y --no-install-recommends bash git curl bzip2 ca-certificates gnupg2 dirmngr patch apt-utils
# Install Miniconda
RUN curl -so ~/miniconda.sh https://repo.continuum.io/miniconda/Miniconda3-4.5.11-Linux-x86_64.sh \
  && chmod +x ~/miniconda.sh \
  && ~/miniconda.sh -bfp ${TARGET}
# Create a Python 3.6 environment
RUN conda config --system --set auto_update_conda false \
  && conda config --system --set always_yes yes \
  && conda config --add channels conda-forge \
  && conda install -y python=3.6.6 pip pycrypto setuptools gdbm pygit2 git \
  && conda clean -ya
RUN ln -s ${TARGET}/etc/profile.d/conda.sh /etc/profile.d/conda.sh

RUN git clone https://github.com/saltstack/salt.git && cd salt && git checkout "${SALT_COMMIT}"

SHELL ["/bin/bash", "-c"]

~~ CUT ~~

RUN source /etc/profile.d/conda.sh && conda activate \
  && cd /salt && python3 setup.py --salt-root-dir=${TARGET} install
@waynew

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

👍 that was enough, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.