Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018.3.3 missing a patch to salt/modules/nxos.py #50966

Open
klafkoff opened this issue Dec 21, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@klafkoff
Copy link

commented Dec 21, 2018

Description of Issue/Question

Running salt cisco.switch.blah nxos.cmd show_ver

I found this error

cisco.switch.blah:
The minion function caused an exception: Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/salt/minion.py", line 1607, in _thread_return
return_data = minion_instance.executors[fname](opts, data, func, args, kwargs)
File "/usr/lib/python2.7/site-packages/salt/executors/direct_call.py", line 12, in execute
return func(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/salt/modules/nxos.py", line 62, in cmd
for k in kwargs:
RuntimeError: dictionary changed size during iteration

I found this patch for a different module, applied it to nxos.py manually, and it resolved the issue -- rallytime@430c462

This is fixed in the develop branch

@garethgreenaway

This comment has been minimized.

Copy link
Member

commented Dec 26, 2018

@klafkoff Thanks for the report. It appears that that change is present in the 2018.3.3 tag, https://github.com/saltstack/salt/blob/v2018.3.3/salt/proxy/fx2.py#L331. Can you confirm that you have the 2018.3.3 installed with salt --version-report? Thanks!

@klafkoff

This comment has been minimized.

Copy link
Author

commented Dec 26, 2018

This is for salt/modules/nxos.py ---- not ---- salt/proxy/fx2.py.

What I am saying is: the patch for the fx2.py resolved the issue with the salt cisco nx-os bug -- that I opened this issue about.

@UtahDave

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

This is fixed by #51080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.