Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saltmod.state doesn't respect "roster" argument #51158

Closed
AndreiPashkin opened this issue Jan 12, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@AndreiPashkin
Copy link
Contributor

commented Jan 12, 2019

Description of Issue/Question

According to the documentation saltmod.state module must accept roster argument:

roster
In the event of using salt-ssh, a roster system can be set

If you analyze the code you'll see that roster argument is not handled in any way.

Setup

This is a basic orchestrate SLS-file that reproduces the issue.

deploy:
  salt.state:
    - tgt: '*'
    - highstate: true
    - pillarenv: live
    - saltenv: live
    - ssh: true
    - roster: my_custom_roster_system

Steps to Reproduce Issue

  • Make any Salt-Orchestrate setup that uses saltmod.state function.
  • Provide an alternative roster system through roster argument.
  • Observe that the default flat roster system is still used.

Versions Report

Salt Version:
           Salt: 2018.3.3
 
Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.7
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 3.6.7 (default, Oct 22 2018, 11:32:17)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5
 
System Versions:
           dist: Ubuntu 18.04 bionic
         locale: ANSI_X3.4-1968
        machine: x86_64
        release: 4.15.0-43-generic
         system: Linux
        version: Ubuntu 18.04 bionic
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

@AndreiPashkin Thanks for reporting this. I have confirmed it is an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.